search

UnaNancyOwen / VelodyneCapture

VelodyneCapture is the general capture class to retrieve the laser data from Velodyne sensors using Boost.Asio and PCAP
MIT License
54 stars 21 forks source link

Error in capturePCAP #40

Closed AJMena closed 2 years ago

AJMena commented 5 years ago

Hello there. There's an error in capturePCAP in this line: ss << header->ts.tv_sec << std::setw( 6 ) << std::left << std::setfill( '0' ) << header->ts.tv_usec; It should be like this: ss << header->ts.tv_sec << std::setw( 6 ) << std::right << std::setfill( '0' ) << header->ts.tv_usec; The '0' were filled at the end instead of between tv_sec and tv_usec. So, the times sometimes were incorrect. Hope it helps. P.S. I'm not sure if this is the way of creating a pull request. First time doing one.

UnaNancyOwen commented 5 years ago

Please send only changes of #39.

lasdasdas commented 4 years ago

I just pushed the fix to the master as it was very small. This MR can be closed. Thanks @AJMena for both of your fix proposals.