UnamSanctam / SilentXMRMiner

A Silent (Hidden) Monero (XMR) Miner Builder
MIT License
557 stars 162 forks source link

how donate works in xmrig #206

Closed Toxenskiy closed 3 years ago

Toxenskiy commented 3 years ago

you are offline or not answering

UnamSanctam commented 3 years ago

What? I'm on my phone at the moment, did you write something anywhere?

Toxenskiy commented 3 years ago

"how donate works in xmrig"

Toxenskiy commented 3 years ago

apparently you do not receive a notification if I do not indicate anything in the comment of the topic

UnamSanctam commented 3 years ago

Yeah it seems that way. But works in what way? If it's at 5% the it will mine to the dev adress for 5 minutes every 100 minutes (mine normally for 95 minutes then mine to dev for 5 minutes) if that's what you mean.

Toxenskiy commented 3 years ago

judging by all tests with donate-lvl = 5 it takes 10 minutes to mine

UnamSanctam commented 3 years ago

Hmm I've nerver tested anything so I'm not sure. How are you measuring it?

Toxenskiy commented 3 years ago

process hacker

UnamSanctam commented 3 years ago

What are you checking in Process Hacker to check it? So that I can test that myself.

Toxenskiy commented 3 years ago

can you believe me

Toxenskiy commented 3 years ago

I even have a video. like I can't look at the process hacker for 100 minutes without stopping

UnamSanctam commented 3 years ago

Oh sure I believe you but I want to do some tests to see why it would do that. It should be maxed at 5 min at the moment so it shouldn't be able to go over that.

Toxenskiy commented 3 years ago

why do you need to conduct a test if first you should look at the source code, and I think it's not very important.

UnamSanctam commented 3 years ago

Yeah it's maxed at 5 in the source which is why I have to test it incase there is something wrong.

Toxenskiy commented 3 years ago

i would advise you to test this on the original xmrig first. for this, you can use the process monitor or other programs that allow you to monitor packages

UnamSanctam commented 3 years ago

Yeah I'm going to test both at the same time

Toxenskiy commented 3 years ago

there is some news on that suggestion

Toxenskiy commented 3 years ago

Well, how's your progress?

Toxenskiy commented 3 years ago

and again you ignored me on the question "there is some news on that suggestion"

UnamSanctam commented 3 years ago

Well I wasn't home at the time so I missed the message since I don't have notifications on my phone. I did test it but it seems a bit weird. If I check with wireshark then both the normal XMRig and the custom XMRig and donate-level=5 usually donates for between 4-7 minutes (only tested both 3 times) but I'm not sure why it does that since it should switch the pools instantly. Maybe there is some sort of delay with the pool or the computer but it seems I have to test it with other settings like another pool maybe.

Toxenskiy commented 3 years ago

with my tests, exactly 10 minutes not a second more, not a second less

Toxenskiy commented 3 years ago

with the original did not test

Toxenskiy commented 3 years ago

I think there is nothing wrong with that, if you want you can put 2-3% by default

I think you better spend your time on some cool update, they have not been there for a long time

UnamSanctam commented 3 years ago

Hmm, and that's with donate-level=5? The code is as follows:

 if (level >= kMinimumDonateLevel && level <= 5) {
        m_donateLevel = level;
    }

So it shouldn't be able to go over 5 even if you put it higher.

I'm planning on a new update soon with new features.

Toxenskiy commented 3 years ago

the last significant update was 1.5 months ago What update are you planning, if not a secret? And also I know 3 hidden miners and they also mine for 10 minutes with donate-lvl = 5 so this is how it should be

UnamSanctam commented 3 years ago

Well that depends on what counts as significant (all the changes and what they do are here https://github.com/UnamSanctam/SilentXMRMiner#changes) but I'm planning on adding an uninstaller for the miner that you can enable to be built in the 'Advanced Options' window. I am also planning the remote configuration on pastebin or something like it where you can enter the pool and everything there and it will load it every time it runs.

Toxenskiy commented 3 years ago

well, you already did it, just unofficially.

Toxenskiy commented 3 years ago

Hmm, and that's with donate-level=5? The code is as follows:

 if (level >= kMinimumDonateLevel && level <= 5) {
        m_donateLevel = level;
    }

So it shouldn't be able to go over 5 even if you put it higher.

I'm planning on a new update soon with new features.

and before it is not necessary to change this variable, you can change the variable in which the mining time is indicated and multiply or increase it

UnamSanctam commented 3 years ago

Yes of course but I believe it's still the normal one, I can't remember ever having changed it. This is the code from the DonateStrategy file and to me it looks like it calculates it correctly.

 m_donateTime(static_cast<uint64_t>(controller->config()->pools().donateLevel()) * 60 * 1000),
    m_idleTime((100 - static_cast<uint64_t>(controller->config()->pools().donateLevel())) * 60 * 1000),
Toxenskiy commented 3 years ago

possibly

Toxenskiy commented 3 years ago

Well that depends on what counts as significant (all the changes and what they do are here https://github.com/UnamSanctam/SilentXMRMiner#changes) but I'm planning on adding an uninstaller for the miner that you can enable to be built in the 'Advanced Options' window. I am also planning the remote configuration on pastebin or something like it where you can enter the pool and everything there and it will load it every time it runs.

however, I think the detections will increase in part because connecting to github or pastebin is already suspicious

UnamSanctam commented 3 years ago

Yes it might, that's also the reason I had to change the original dev server from donate.v2.xmrig.com to something else because the traffic to it made it really easy to detect the miner and even made it so that your IP could be blocked in places where that server is on a blocklist.

Toxenskiy commented 3 years ago

well, you already did it, just unofficially.

and besides, it is difficult to call it significant

UnamSanctam commented 3 years ago

Then what would you call significant?

Toxenskiy commented 3 years ago

watchdog

UnamSanctam commented 3 years ago

Yes but what possible new feature would you call significant? There isn't that many big features I can add without increasing detections or complexity in the builder.

Toxenskiy commented 3 years ago

need to think

Toxenskiy commented 3 years ago

the ability to update miners

UnamSanctam commented 3 years ago

Yes that's what I was considering adding to the remote configuration with pastebin as well (so you could add a link to the miner on another row of the text) but a test I did before made it detected as a 'Downloader' by some antiviruses so I probably have to find some method of doing it that's not detected.

Toxenskiy commented 3 years ago

try doing everything in memory without saving to disk

Toxenskiy commented 3 years ago

that is, so that the file is downloaded and launched in memory, and after starting the miner will be saved in the path specified in the build

UnamSanctam commented 3 years ago

Yeah but it's the actual download it detects so it detects it before the download is complete.

Toxenskiy commented 3 years ago

no thoughts at all.

UnamSanctam commented 3 years ago

Yeah, I'll try using other methods of downloading it until it stops detecting it.

Toxenskiy commented 3 years ago

yes, but my idea is that the miner is updated but a new version when you release it, and not make a loader

UnamSanctam commented 3 years ago

That only the XMRig miner gets updated and nothing else (i.e it downloads this file)? I guess I could do that but I'd have to make sure that the miner always stays backwards-compatible but that shouldn't be that difficult.

Toxenskiy commented 3 years ago

you understood me correctly

Toxenskiy commented 3 years ago

there is still one suggestion when cloning a file to a path to remove the icon

Toxenskiy commented 3 years ago

i just think if a person finds a file in my APPDATA with the name Services and with a game or browser icon he will find it strange

UnamSanctam commented 3 years ago

Yeah, only issue I'll have to think about is that the Icon is directly in the assembly so it's not as easy as it sounds but it might be possible to change the resources of the file to remove it (in a relatively easy way).