Support for PyTorch 2.0

Unbabel / COMET

A Neural Framework for MT Evaluation

https://unbabel.github.io/COMET/html/index.html

Apache License 2.0

493 stars 76 forks source link

Support for PyTorch 2.0 #126

Closed HennerM closed 1 year ago

HennerM commented 1 year ago

PyTorch 2.0 was released two weeks ago: https://github.com/pytorch/pytorch/releases

To make COMET compatible with installations that updated to PyTorch 2.0 already, we can loosen the version restriction on PyTorch. I ran the unit tests and they all passed. Most changes in 2.0 are backwards compatible, so I wouldn't expect any issues.

closes #119

HennerM commented 1 year ago

@ricardorei is this something you can have a look at?

Disallowing PyTorch >=2 makes COMET uninstallable for packages that have the latest PyTorch as dependency

ricardorei commented 1 year ago

Sorry. This is not forgotten but I did not had time to look into it.

I'll set aside some time for tomorrow to merge this and bump the pypi version to (2.0.1).