Fix Contributing.md - Githubissues

Unbabel / OpenKiwi

Open-Source Machine Translation Quality Estimation in PyTorch

https://unbabel.github.io/OpenKiwi/

GNU Affero General Public License v3.0

229 stars 48 forks source link

Fix Contributing.md #2

Closed captainvera closed 5 years ago

captainvera commented 5 years ago

Made a pull request so I can get some feedback on this.

Do you think there's anything missing? Or something that should be changed?

@kepler @trenous

captainvera commented 5 years ago

One thing I didn't touch is the recommendation to use click instead of argparse. But I've noticed we have a lot of scripts (like the evaluation) which use argparse. I don't think we use click anywhere. So can I remove that?

kepler commented 5 years ago

Yes, the recommendation on click is completely outdated. It was basically in the very first commit of the project, when we hadn't decide on the CLI parser.

kepler commented 5 years ago

@captainvera Let me know when you merge these suggestions so that we can close this PR.