search

Unbabel / OpenKiwi

Open-Source Machine Translation Quality Estimation in PyTorch
https://unbabel.github.io/OpenKiwi/
GNU Affero General Public License v3.0
229 stars 48 forks source link

Fix CI by avoiding conflict between torch and pytorch lightning #89

Closed daandouwe closed 3 years ago

daandouwe commented 3 years ago

Master started failing since the last PR was merged. This is to solve that.

daandouwe commented 3 years ago

I could not run the docs CI on circleci, but the following local experiment confirmed that things are now fixed.

With the code in this PR (torch<1.7.0):

$ poetry run sphinx-build -b html -d docs/.doctrees docs gh-pages
...
build succeeded, 28 warnings.

The HTML pages are in gh-pages

When I did pip install torch==1.7.0:

$ poetry run sphinx-build -b html -d docs/.doctrees docs gh-pages
...
[1]    5054 segmentation fault  ~/.poetry/bin/poetry run sphinx-build -b html -d docs/.doctrees docs gh-pages