search

Unboxed-Software / solana-course

A complete course for learning Solana, including creating and transferring tokens, making NFTs, on-chain app development, and more.
https://solana.com/developers
Mozilla Public License 2.0
395 stars 134 forks source link

Updated the intro to writing data page since it was missing steps to … #275

Closed Aheesh closed 8 months ago

Aheesh commented 9 months ago

…create a connection and to run the program. Removed the airdrop portion as this is already covered in the earlier section and it breaks the continuity of the tutorial.

mikemaccana commented 9 months ago

Hi @Aheesh I don't understand this PR. The existing code makes a connection, and sends the transaction (await web3.sendAndConfirmTransaction(...)). Removing the airdrop section is a good idea, as you mention this is already covered in other sections. Do you want to fix the PR to just focus on that and fix anything else that is actually missing?

Aheesh commented 9 months ago

Thanks for the review. Incorporated the recommended changes.

Aheesh commented 9 months ago

Please review, included Prettier formatting and removed main() codeblock.

Aheesh commented 8 months ago

Any other feedback or comments ?

mikemaccana commented 8 months ago

Thanks @Aheesh !

mikemaccana commented 7 months ago

@Aheesh just a heads up this PR made changes to the wrong chapter and we reverted it.