search

Uncaught-Exceptions / MCRcon

Use minecraft's new-fangled Rcon
Other
51 stars 12 forks source link

Cross-platform timeout support #12

Open StevenLu2004 opened 3 years ago

StevenLu2004 commented 3 years ago

Apparently, the major change in version 0.7.0 is the addition of timeouts. But I can't understand why it's non-Windows or why signal is used instead of socket.settimeout. Could we have done better?

unexceptable commented 3 years ago

Hey! So if you can make this work better, I'll gladly test and confirm your change then merge it, but if you take a look at this pull request you'll see the issues someone ran into trying to use that already and why windows was skipped: https://github.com/Uncaught-Exceptions/MCRcon/pull/8