Closed tmigot closed 4 months ago
Thank you for your feedback and sorry for taking this much time to respond. I agree on your suggestion to clarify the theoritical guarantees but shouldn't I redirect to the documentation for a description of the method? I might be wrong about it but I wanted to keep the optimization aspects of the paper brief and just state in what category the method belongs to. Also thanks for the topic comparing least squares solvers packages!
It is true, though but it is possible to give a short description of the algorithm in 2-3 sentences.
Hi! I just pushed a revised version of the paper of the joss-paper branch. I added a brief description of the algorithm and the theoretical guarantees in addition to a paragraph on comparison tests between Julia and Fortran.
Can we close this issue when it is done?
Hi @pierre-borie ! I have more comments regarding the paper:
Hi @tmigot , thanks for your comments! Just to make sure I get these right:
@tmigot - I submitted a new version of the paper that will, I hope, address your latest comments!
[x] Typos:
[x] Summary: Has a clear description of the high-level functionality and purpose of the software for a diverse, non-specialist audience been provided? I think the theoretical guarantees offer by the solver should be clarified for a general audience. For instance, I assume this is not a global optimizer. In general, the paper should target a broad audience.
[x] I think the paper lacks a brief description of the algorithm. It is not clear if this uses the second-order derivatives of the involved function or if the active-set strategy used in the paper is exactly the same as in the book by Nocedal & Wright ...
[x] Data sharing: If the paper contains original data, data are accessible to the reviewers. If the paper contains no original data, please check this item. A large part of the discussion in the paper is comparing the Fortran version vs. the Julia version while there is no shared data on this.
[x] This recent post could help the author expand the list of existing solvers for (unconstrained) NLS https://discourse.julialang.org/t/comparing-non-linear-least-squares-solvers/104752.
[x] It would also help states why we consider the NLS case separately to the classical optimization case.
https://github.com/openjournals/joss-reviews/issues/6226