Closed titis14 closed 3 years ago
Currently everything is hardcoded unfortunately. But having an i18n translation file is definitely on the list of improvements now. I'm changing the issues title and would come back to you for a french translation once this is done. Would this work for you?
Hello, Ok great I'm waiting for your return to be able to do the translation :)
Hi there. I can translate it to German if it rdy. :)
I can translate to Slovenian...
Hi Could you please give me a language translation tutorial?!
Also interested to help traduct in french :)
I have located and translated all hard-coded strings of the app to french, i can implement this feature if the correct structure is implemented, or at least advised (long time since i worked on an angular app, i would not be the right person to choose the plugins and file architecture).
If no indication is given, i will start tomorrow. We have just rebased our branch to your latest main, and most changes are in conflict so i'll be faster implementing it correctly than fixing the merge :)
If you have any indication to which plugin to use, that would be helpful.
Didn't had a thorough look at the possibilities yet, but ngx-translate
seems promising, but I'm open to other libraries / the default i18n localisation as well. It should be able to:
If you find something let me know and I can have a look at that :)
I'm following this at the moment: https://angular.io/guide/i18n
about the difference between ngx-translate and native i18n: https://github.com/ngx-translate/core/issues/495
Mostly done, will PR tomorrow
Thanks to @pciavald this has been implemented and a french translation is also available. If anyone of you want to add another translation please feel free to do so. A how-to is available in the CONTRIBUTING file. Thanks :)
Hi there. I can translate it to German if it rdy. :)
Hi @Der-WU , can you help me with the translation to germany? I need this for a projekt in a few days.
Or can someone else help me who is familiar with it?
Are you having issues with these instructions? https://github.com/UnchartedBull/OctoDash/blob/main/CONTRIBUTING.md#add-a-new-language
Yes I can't follow the instructions properly somehow. Is there a video or something?
none that I'm aware of. Have you at least got to the point where you have a german xlf file?
No, unfortunately not. The npm somehow doesn't work either. No matter what command I enter nothing comes back
you can just copy this file and fill in the "target" sections for the german equivalent. https://raw.githubusercontent.com/UnchartedBull/OctoDash/main/src/locale/messages.fr.xlf
once you have that I might be able to build you a version tonight that will work.
Okay I understand that. How do I go on then?
okay thank you very much
Can you then show me how it works?
I've never done it, so would have to figure that part out, but have a local development setup of OctoDash at home. Pretty sure it's just a bunch of copying/pasting of source files in OctoDash to add the language.
okay, I'll translate it now
Just a heads-up, I won't be home for about 6 hours, but can definitely try the process for you then. I'll keep screenshots and such to document the process for others.
Okay, Thank you
Okay, I'm ready with the file.
Please share the file here (just drag&drop) or create a PR
Okay it's not perfect yet, but i will optimize it when it works
Could you send me a short video recording in which you translate it with the file?
I think the line needs to be updated.
<file original="ng2.template" datatype="plaintext" source-language="en" target-language="fr">
to
<file original="ng2.template" datatype="plaintext" source-language="en" target-language="de">
https://github.com/UnchartedBull/OctoDash/tree/feature/german-translation I created this branch. Everything is working there. You just need to execute ng serve --configuration=de & npm run electron:serve:big
to get the development server up and running. I'll attach a deb file once the build is through.
On a site note: The translation do need a bit of work, not a huge fan of "Sie" and I think "Du" might be better suited for something like OctoDash, plus some texts are fairly long, so they might not fit in their designated spots.
@jneilliii updated that in the linked branch already.
https://drive.google.com/file/d/1ZEMsNEkgBzbXCeqP38lXdsOoH-Gs44Ys/view?usp=sharing here is the deb with the included german translation
Okay, thank you very much, I'll test it out and then improve the translations again.
what do I have to do now?
How can I actually create such a .deb? and then how do i use it?
I have github actions on my fork of OctoDash that will build the deb files. It's part of the packaging process. Once you have the deb file, you transfer it to your pi and use the command sudo dpkg -i ./octodash.deb
from the folder you saved to via SSH or the terminal.
npm run pack
will package into a deb file. not sure if you have to pass additional parameters for a different language or not to that command.
Okay and how i can start octodash now?
memory access failure
did you run through the standard install script first? I would do that and then install over the version it installs with the de one. then run sudo service getty@tty1 restart
to have it restart.
Yes now it worked. Many Thanks. Can I actually personalize the symbols?
Can one of you show me how I can create the .deb?
Like I mentioned before, npm run pack
from the folder where the code is will compile the code into a deb file. I do not know if you have to pass any parameters to that for specific language or not.
npm run pack always creates a .tgz file for me
that's a compressed file. should be able to be extracted. on windows I use 7 zip.
Yes I know, but I need a .deb file
Hello I installed octodash on my pi with a 7 inch screen in 1024x800 I am delighted with this application. I would like to know if the French translation is possible? I would like to contribute to translate the application. Is this easily done from a language file or is everything hard in the code? Thank you