Do not add to list non-games (i.e. software or comic books)

UncleGoogle / galaxy-integration-humblebundle

Humble Bundle integration for GOG Galaxy 2.0

GNU General Public License v3.0

188 stars 18 forks source link

Do not add to list non-games (i.e. software or comic books) #11

Closed PastorGL closed 5 years ago

PastorGL commented 5 years ago

I bought a number of software bundles, and now I have, for example, ACDSee and Aurora HDR in the game list (among others):

If I click a non-game, the Overview screen looks like this:

Not very useful %)

UncleGoogle commented 5 years ago

Thanks for report. Looks like Galaxy games database is curated manually, so you probably won't see all non-games after some time.

Anyway, I'll keep this issue open, to check for a way to make better filters it in a free time. Currently there is quite dummy check to exclude only items that have no direct downloads for windows, mac or linux...

@PastorGL could you check this StudioUltimate json data?

open devtools
click on Network tab
nagivate to https://www.humblebundle.com/home/library
click on after one on requests of name like on image below
search for product name (Photo Studio..) in Response subtab

39055cc457338616633fa89f1ed95a38

if found, copy whole response content and paste here on in a file. There is no sensitive data beside amount of spend $ so you can remove it

PastorGL commented 5 years ago

It was a 'Humble Software Bundle: Professional Photography': 1.zip

Huh, it was a bit hard to find the right request. Never realized that I've acquired 44 bundles through the years, htat's quite a number.

UncleGoogle commented 5 years ago

@PastorGL could you check this build logs? Ignored entries should be logged like that: Ignoring xxx due to bundle type: yyy

humblebundle_0.3.2.zip

PastorGL commented 5 years ago

@UncleGoogle yes, there are log records like 2019-08-21 22:41:07,998 - root - DEBUG - Ignoring vegasproevenmore_softwarebundle due bundle type: softwarebundle 2019-08-21 22:41:08,000 - root - DEBUG - Ignoring professionalphotography_softwarebundle due bundle type: softwarebundle and programs no more appear in the list.

Thank you!

UncleGoogle commented 5 years ago

Thanks for testing :) Changes merged, but it will be deployed in 0.4 release (https://github.com/UncleGoogle/galaxy-integration-humblebundle/milestone/3)