Resolve duplications (owned game ids vs games from subscriptions)

[UncleGoogle]

Reserach:

We have such sources of information:

• orders API (list of orders from home/library) - currently used for returning owned games (subproducts & keys separately in library.py)
• subscriptions API (list of unlocked subscription months with some (not all!) list of games to pick & list of currently unlocked games in form of subscription_game ids (probably all of them)) - currently used to determine which sub. months are unlocked
• weback parsed from subscription/- with similar info as above, but with all subscription games to pick. Includes tpkds info but there is no subproducts (dre-free)! Extrases are included with machine_name matching the one from final tpkds/subproduct from orders API (probably they are there from the very beginning) so it should come from library.py.

And one more thing to check: unlockedContentEvents. In march it looks like that:

"unlockedContentEvents": [
      "initial",
      "planetcoaster",
      "planetcoaster_dlc",
      "f12019anniversaryedition"
    ],
    "contentChoicesMade": {
      "initial": {
        "choices_made": [
          "f12019anniversaryedition",
          "planetcoaster"
        ]
      }
    },

This additional planetcoaster_dlc is only there - it not matches any known machine_name.

Need to check if planetcoaster_worldsfairpack_choice_steam comes in API orders as a steam key when you have not chosen planetcoaster. That would be complication.

Similar case in january with dirt and grip games with DLCs. Need to ask someone who have not claimed it what he see when click "GET Extras". Are dirt DLC there or not?

[UncleGoogle]

After rethinking IMO best solution is "won't do". So Galaxy is responsible to group proper ids into one game whether it reported as subscription game or as key to reveal/ extras ect. User has to open proper id-game view to chose proper behavior on clicking Install.

Logic for install behavior depending on id should be:

• ids from owned subproducts or keys: Clicking install triggers download or open Key GUI as usual
• ids from Choice games: Clicking install opens subscription/<month>-<year> if month not unlocked yet or subscription/<month>-<year>/<game_id> if unlocked
• ids from Choice extrases should be the same in both cases - then priority have owned subproducts or keys.

Potential problem is someone want to open subscription/<month>-<year> page using Extras to check from which month it comes, but it won't work like that. Workaround is to link subproducts/keys objects with subscription name and in such case look for subscription extrases - if there is also such id there. But for now - won't do, as unnecessary complication.

---

Alternative solutions was:

• use resolved subproducts/keys whenever possible - also returning them from within get_subscription_games method - rejected as too complicated
• customize by adding option to use "picker mode" - where resolved subproducts/keys comming from subscriptions will be filtered out from get_owned_games - rejected as more work that gives not so much (Galaxy deduplication and filters work good)
• customize by adding option to use "choice mode": (default, current get_subscription_games implementation) - shows subscription games, independent from owned_games game ids; unselected "choice mode" will use the cached owned_games which keep additional info about product source so ONLY ALREADY CHOSEN Humble Choice games are shown with no duplication problems.

As Galaxy allows to filter subscription_games I decided to leave current implementation (aka choice mode that cannot be changed)