Blacklist for splitting multigame keys

UncleGoogle / galaxy-integration-humblebundle

Humble Bundle integration for GOG Galaxy 2.0

GNU General Public License v3.0

187 stars 18 forks source link

Blacklist for splitting multigame keys #126

Closed UncleGoogle closed 4 years ago

UncleGoogle commented 4 years ago

Fixes #100

tldr Previously all keys that have coma in human_names where splatted into multiple keys as this was the only way to extract all real games from one key using humble API.

This PR tries to avoid false positives by ignoring non-bundles and using blacklist for games that have "real" coma in their titles. In the future blacklist may be extended. Whitelist also maybe added in case there are keys that have multiple coma-separated games, but at least one of them is blacklisted.

lgtm-com[bot] commented 4 years ago

This pull request introduces 2 alerts when merging d1db4cd6f8855b20cca3101401b72c6e73c891e8 into 503c8b3d6550b91eeaa39bbbd2822017de64e998 - view on LGTM.com

new alerts:

1 for Unused import
1 for Implicit string concatenation in a list