Rework getting subscriptions list - Githubissues

UncleGoogle / galaxy-integration-humblebundle

Humble Bundle integration for GOG Galaxy 2.0

GNU General Public License v3.0

187 stars 18 forks source link

Rework getting subscriptions list #138

Closed UncleGoogle closed 2 years ago

UncleGoogle commented 4 years ago

Should fix #165 #167

more reliable source of username
fix getting username for non-subscribers
separate "not-yet-unlocked choice content" users from "never-subscriber" users in terms of fetching active content product machine name
some refactors

lgtm-com[bot] commented 4 years ago

This pull request introduces 3 alerts when merging 43550dfc0f426fcbeada5c88423822125571103e into 96e32147804e3f70915b9cf03dda228b40bf9b5f - view on LGTM.com

new alerts:

2 for Unused import
1 for Wrong number of arguments in a call

lgtm-com[bot] commented 2 years ago

This pull request introduces 1 alert when merging f0f7316ed3720cc0884331831e1441179e42eacd into 046e1e37c28ea1107b6e5c904bb8ba593124fbc2 - view on LGTM.com

new alerts:

1 for Unused import

lgtm-com[bot] commented 2 years ago

This pull request introduces 2 alerts when merging 12203011afb1b1b176a61a39959cdd70f4aa56aa into ffe063ed3c047053039851256cf23a5343317f2e - view on LGTM.com

new alerts:

2 for Unused import

lgtm-com[bot] commented 2 years ago

This pull request introduces 2 alerts when merging 63c29972e23162de56506d97e3e589cd00d83c9b into ffe063ed3c047053039851256cf23a5343317f2e - view on LGTM.com

new alerts:

2 for Unused import

lgtm-com[bot] commented 2 years ago

This pull request introduces 1 alert when merging 68ddfc98022117c3c04e4556628683efccc1249e into ffe063ed3c047053039851256cf23a5343317f2e - view on LGTM.com

new alerts:

1 for Unused import

lgtm-com[bot] commented 2 years ago

This pull request introduces 1 alert when merging 6adf13c0e0e3614419c192283bd053b586c5771b into ffe063ed3c047053039851256cf23a5343317f2e - view on LGTM.com

new alerts:

1 for Unused import

UncleGoogle commented 2 years ago

to myself: continue WIP commit from trove_from_last_sub_strategy_draft