Gwindalmir
commented
3 years ago Hi @Gwindalmir, thanks for the PR!
There are many bundles
Any other example? I'm asking because the matching algorithm in GOG works only for the first-time ever import. Once the plugin import game name such as "and Sacred Citadel" then it has to be fixed manually by sending ticket to GOG. So if it is one-time only accident, then maybe it is not worth to add. Otherwise lets merge it and hope Humble stuff uses
, andand not forgets the coma...Yes, there were several games that tripped up on that, at least two. My library is all corrupted now though, I have games that don't appear anymore (like Operator). Here's what shows in the logs:
- Metro 2033, Risen, and Sacred Citadel : deepsilver_bundle_mpa_steam
- XCOM: Enemy Unknown, Sid Meier’s Pirates!, Ace Patrol Bundle, and Sid Meier's Civilization III Complete : firaxisbundle_bt1_steam
- X-COM: Complete Pack, Sid Meier's Civilization V: Scrambled Nations Map Pack, Sid Meier's Civilization V: Scrambled Continents Map Pack, and Sid Meier's Civilization V: Gods & Kings : firaxisbundle_mpa_steam
- Crayon Physics Deluxe, Aquaria, and Dungeons of Dredmor Steam Key : introversionsteambta
- Shogun: Total War Collection, Medieval II: Total War Collection, Viking: Battle for Asgard, and Total War: ARENA Beta Access Key : totalwar_bundle_coretier_steam
- Total War: ROME II - Emperor Edition, Total War: ROME II - Wrath of Sparta Campaign Pack, Total War: ROME II - Caesar in Gaul Campaign Pack, Total War: ROME II - Nomadic Tribes Culture Pack, and Total War: ROME II - Pirates and Raiders Culture Pack : totalwar_bundle_bt15_steam
However, the only other one I see in my library currently is and Total War: ARENA Beta Access Key.
I've commented on some minor things to change. Please rebase to keep this 2 separate commits for 2 logical changes (I'll fast forward it when merging) or put the blacklist fix in separate PR.
Uh what? I'm not very good with git.
One more think is maybe to add another "split" test(s) to ensure there is no false positives? Having parametization for names (and expected results) like "game A, Ori and Blind Forest", "Forever, and ever" (welp, we've already agreed on such side effect counting on GOG to spam "ever"), "game A, and game B, and game C" (to show the whole logic., "game A, And another request 2" (to show immune to capitalized text) ect.
I can do that.
UncleGoogle
There are many bundles, such as the Deep Silver Bundle, which include the word "and" in the title string for the multi-game key bundle. One example is: Metro 2033, Risen, and Sacred Citadel This caused Galaxy to add a game called "and Sacred Citadel" to my list.
I added an extra check in the split code to check for the word "and", in lowercase. From what I've seen, that title isn't localized, and is always in English.
There's a second minor fix in there, which is for the blacklist. The Star Wars games recently had their titles changed when Disney bought the franchise and started releasing updates again. Battlefront and Battlefront II are examples. The current blacklist is case sensitive. My fix is to perform a case insensitive comparison of the blacklist.