UncleGoogle / galaxy-integration-humblebundle

Humble Bundle integration for GOG Galaxy 2.0
GNU General Public License v3.0
184 stars 19 forks source link

Can't see humble choice or trove games #161

Closed Bertaz closed 2 years ago

Bertaz commented 2 years ago

Describe the bug Today I noticed that the plugin stopped showing newer choice months from around June. I relogged in the integration hoping to solve it. All my choice months and trove games disappeared, I now only have games from keys and drm-free. I think it's caused by the absence of options in Settings->Features: image I reinstalled the plugin from galaxy, installed the latest release from here, nothing worked

Expected behavior Show all the choice months and the trove

Plugin installed directly from Galaxy AND manually from your repository releases

Provide logs HumblePluginLogs.zip

UncleGoogle commented 2 years ago

Hello @Bertaz,

check this build please

humblebundle_0.9.5a.zip

You will have to reconnect the plugin.

Bertaz commented 2 years ago

That build works. It increased considerably the first import times, before it took less than a minute, now it takes a couple of minutes. Not a problem as it happens only after connecting for the first time.

The subscriptions option under Features reappeared and shows all the humble choices, the newest one for some reason is at the bottom with a star: image But it doesn't appear in the Subscriptions tab: image

Also, after a Galaxy restart, the option under Features disappeared as before, but the already loaded subscriptions remained

[…]the absence of options in Settings->Features: image

humblePluginLog.zip

UncleGoogle commented 2 years ago

Ah, ok, so there was a code leftover from what I've tried to achieve to address this issue: #159 locally on my machine.

I mean - I marked the latest subscription with "*" (a workaround for no option to order subscriptions in Galaxy), but there was one more bug when Galaxy asks for this subscription games. I'll do that later on - if you have any opinions about that - please let me know in corresponding issue.

For now, I'll release the fix for subscriptions.

UncleGoogle commented 2 years ago

Before release I need to also check with account that have never subscribed.

So in case it won't happen this week I'm posting beta build here: humblebundle_0.9.5b.zip

@Bertaz could you check once again? Reconnection needed.

Bertaz commented 2 years ago

Before release I need to also check with account that have never subscribed.

I don't have a never subscribed account, but from #162 I'm guessing you already tested that

@Bertaz could you check once again? Reconnection needed.

Now everything works correctly, except that after a Galaxy restart the option under Features disappears, but the already loaded subscriptions remain:

[…]absence of options in Settings->Features: image

humblePluginLog_5.10.zip

UncleGoogle commented 2 years ago

Hey, thanks for the test.

In plugin logs everything looks good, except that after restart Galaxy just do not ask for subscriptions :(

I think it may be related to https://github.com/gogcom/galaxy-integrations-python-api/issues/180 as also get_owned_games is not called.