UncleGoogle / galaxy-integration-humblebundle

Humble Bundle integration for GOG Galaxy 2.0
GNU General Public License v3.0
184 stars 19 forks source link

High CPU usage from plugin #182

Open SkebbZ opened 2 years ago

SkebbZ commented 2 years ago

I purged the settings file and set it to "drm-free" only.

It connects properly now, but after connecting the entire GOG client slows to a crawl and uses 100% CPU on the "GalaxyClient Helper Application". If I terminate that process the GOG client sort of reloads and imports everything normally after a few seconds.

Seems to work OK, until I restart the client. Then it starts to use around 10-12% CPU on the Python process related to the Humble plugin. I know this because when I terminate it, it says "Humble plugin crashed".

logs.zip

Side note: The entire client was always a bit unstable. Perhaps I just have too many games. If I import my steam account, the entire client crashes or becomes unusable due to having over 4k games there...

At least on Humble I only had 397 drm-free games when I unticked everything else.

Originally posted by @SkebbZ in https://github.com/UncleGoogle/galaxy-integration-humblebundle/issues/177#issuecomment-1128965760

SkebbZ commented 2 years ago

Skjermbilde 2022-05-19 122247

Here's a screenshot from task manager. It keeps going like this forever. The top Python process is the Humble plugin one. System otherwise at idle, and client has been open for about 5 minutes.

For reference I have an Intel i7-8700K running on full Turbo.

EffortlessFury commented 1 year ago

I wanted to add my two cents to this issue as I came here looking for others with similar issues. I did a little digging and using the ever lovely "Everything" file system search tool, I think I found the culprit. Though the plugin itself has stopped performing operations (as all that's being appended are ping log lines), I found that what the Galaxy client is doing is populating the webcache for all of the games the plugin imported. It's slowly downloading files and updating a DB file for games that the plugin reported were imported minutes beforehand.

I think ultimately how GOG handles the importing process is the culprit and the poor performance is a consequence of having and importing a large library.

UncleGoogle commented 1 year ago

@EffortlessFury it's true, but it does not explain high CPU usage on plugin side.

@SkebbZ sorry for the silence, I forget to answer. I've scanned logs and everything seems smooth. I've scanned code and don't have idea about the culprit. But if you are still interested I can try to add more logs and share that plugin version for pair debugging.

EffortlessFury commented 1 year ago

I had high CPU usage as well, but I think it's not ACTUALLY the plugin. I think the high CPU usage is coming from GOG's caching process.