UncleGoogle / galaxy-integration-humblebundle

Humble Bundle integration for GOG Galaxy 2.0
GNU General Public License v3.0
186 stars 19 forks source link

Owned games not fetched (after plugin update by Galaxy) #62

Closed Faedelity closed 4 years ago

Faedelity commented 4 years ago

Describe the bug Literally minutes after adding the integration, I installed A Slow Year as a test of how the integration works- the direct to the download worked fine, I downloaded and installed the game. Galaxy recognized the install, and I now had a "Play" button. Upon pressing it, I got the message at the bottom of the window that a Humble game was being started, but after a few seconds, it went away, and nothing further happened.

To check to see if this was an error with the game itself, I navigated to where I had installed it and ran it directly. It worked fine.

Expected behavior Upon clicking "Play" on an installed game that Galaxy recognizes as installed, game is started.

Plugin installed directly from Galaxy

Provide logs Just so you know, GitHub throws an error if you try to attach a 7z file directly to this issue input area. Not sure if they support uploading them later.

logs.zip

Faedelity commented 4 years ago

Huh. After some time and a Galaxy restart, both this and the issue I was having where Uninstall did nothing have gone away. So... Going to leave this open so you see it and can look at the logs, but it's working now. So... maybe a transient problem or one with files not getting changed at the right time? It failed several times before I decide to post a bug report.

UncleGoogle commented 4 years ago

Hey! Thanks for reaching me out with detailed issue.

This is very interesting and sounds buggy on plugin side. It should work just after game detection, but somehow local_games cache do not contain the game_id you have tried to launch/uninstall. I've prepared version with detailed logging. Could you please try to reproduce with the same game? All steps:

Thanks!

UncleGoogle commented 4 years ago

It has happened to me yesterday just after autoupdate by Galaxy. Restarting Galaxy helps. I'm not sure, but probably just after plugin update, Galaxy forgets to ask about owned games belonging to user. Workaround is to ensure plugin will always ask humble API w/o needed to be requested by Galaxy.

Faedelity commented 4 years ago

Sorry I didn't get back on this for a while. It appears that the version is 0.5.4. now. I am going to do the rest as you have said, let me know if I should have waited for a new version of the files you sent.

UncleGoogle commented 4 years ago

Hey, dont worry. Let us wait for 6.0.0 because mechanics will be changed a bit.

UncleGoogle commented 4 years ago

Should be fixed now