search

UncleGoogle / galaxy-integration-humblebundle

Humble Bundle integration for GOG Galaxy 2.0
GNU General Public License v3.0
186 stars 19 forks source link

Fix for handling titles longer than 100chars #76

Closed UncleGoogle closed 4 years ago

UncleGoogle commented 4 years ago

Galaxy backend do not accept titles longer than 100chars. The problem was reported, as Galaxy Client cannot handle such exceptions (see #65)

But for now - simply workaround it by truncating long titles to max 100 characters.

aserrallerios commented 4 years ago

Forgive my ignorance, but if a single key contains multiple games, shouldn't it be handled in such a way that the same key appears multiple times?

game1,game2,game3 -> key

to

game1 -> key game2 -> key game3 -> key

UncleGoogle commented 4 years ago

@aserrallerios, sure, good point. Keys with multiple names won't even appear in Galaxy (will be spammed).

Real solution is like you said - separate those keys. This PR is rather quickfix to avoid plugin crash.

I would do your proposal separately because logic in code for key separation maybe not so obvious. Feel free to create issue / PR for this.