Wrong tags on games from multiple libraries

UncleGoogle / galaxy-integration-humblebundle

Humble Bundle integration for GOG Galaxy 2.0

GNU General Public License v3.0

187 stars 18 forks source link

Wrong tags on games from multiple libraries #99

Open Bertaz opened 4 years ago

Bertaz commented 4 years ago

Describe the bug If a game is owned both as an unrevealed key and a drm-free game it appears double in gog galaxy (I find this behaviour correct), but both are tagged in only one way, in this case Key and Unrevealed.

Reproduction: Select all game types in the integration options and view the page of a game owned in more than one type.

Expected behavior If possible: the key tagged as key and the drm free tagged as drm-free

Plugin installed manually from your repository releases

Provide logs

make reproduction steps you described above (tip: cogwheel menu -> Sync Integration refreshes owned and local games)
go to logs location:
- (Windows) %programdata%\GOG.com\Galaxy\logs
archive logs to zip/7z file; in most cases those two logs will be sufficient:
attach archive in bug report

wrongTagsHumbleLogs.7z.zip rename to *.7z

UncleGoogle commented 4 years ago

Ah, apparently this is the side-effect of "deduplication" Galaxy feature. Very unfortunate, the whole idea of this distinction ruined!

Can you paste screenshot just to confirm with logs?

Please report to Galaxy mantis bug tracker (Report issue in menu)

Bertaz commented 4 years ago

Ah, apparently this is the side-effect of "deduplication" Galaxy feature. Very unfortunate, the whole idea of this distinction ruined!

Can you paste screenshot just to confirm with logs?

I have this game on steam and humble as drm free, unrevealed key and trove Orwell I attached all the screenshot of games appearing more than once humbleScreens.7z

Please report to Galaxy mantis bug tracker (Report issue in menu)

What should I report? The tags shared by different types of the same game?

UncleGoogle commented 4 years ago

Report that you want have tags per release not per game and link this issue.

Bertaz commented 4 years ago

Link to mantis issue https://mantis2.gog.com/view.php?id=55580

UncleGoogle commented 4 years ago

Thanks! Currently there is separate interface for Trove games (Galaxy subscription feature) so we not don't need special tag for Trove since next 0,8 plugin version.

But there is still need for mapping Keys and Unreaveled tags for something useful. Native support for keys in Galaxy would solve that problem. Or tags imported per release (per library).