feature: added driver for ds2438 sensor

UncleRus / esp-idf-lib

Component library for ESP32-xx and ESP8266

https://esp-idf-lib.readthedocs.io/en/latest/

1.38k stars 429 forks source link

Closed horsemann07 closed 2 years ago

horsemann07 commented 2 years ago

I added the driver code ds2438 and some helper macros. Unfortunately, I did not test the code on the device because I do not have one.

trombik commented 2 years ago

there are several incompatibilities with our styles and policies in your code. See CONTRIBUTING.md.

also, we do not accept copy-and-paste code.

horsemann07 commented 2 years ago

Hello @trombik,

Thanks for the comment. I will try to change the code as per your coding styles.

Other than that, I tried to convert the Arduino code of ds2438 for esp32.

Thanks.

trombik commented 2 years ago

Other than that, I tried to convert the Arduino code of ds2438 for esp32.

please don't. the code is not compatible with our acceptable licenses.