search

UncleRus / esp-idf-lib

Component library for ESP32-xx and ESP8266
https://esp-idf-lib.readthedocs.io/en/latest/
1.37k stars 426 forks source link

sgm58031: add component + examples #511

Closed jmpmscorp closed 1 year ago

jmpmscorp commented 1 year ago

Let me know if something must be changed.

trombik commented 1 year ago

the build failed due to bugs in other code. i'll take a look.

trombik commented 1 year ago

the failed jobs: https://github.com/UncleRus/esp-idf-lib/actions/runs/4813471723/jobs/8570050373

jmpmscorp commented 1 year ago

@trombik I have found errors related with esp32s3 build. I just upload a PR.

On the other hand, esp32c3 error is similar. On LS7366R component example, this line:

#define LS7366R_HOST SPI3_HOST

produces the error, because in esp32c3 target SPI3_HOST is undefined. esp32c3 has only SPI2_HOST available.

trombik commented 1 year ago

the PRs have been merged. would you rebase this branch with the latest master branch?

jmpmscorp commented 1 year ago

the PRs have been merged. would you rebase this branch with the latest master branch?

Just done.

UncleRus commented 1 year ago

Thank you!