UncleRus / esp-idf-lib

Component library for ESP32-xx and ESP8266
https://esp-idf-lib.readthedocs.io/en/latest/
1.37k stars 426 forks source link

sts3x driver implementation #537

Closed slimcdk closed 1 year ago

slimcdk commented 1 year ago

New pull request for sts3x implementation #531

UncleRus commented 1 year ago

Default example for sts3x (/examples/sts3x/default) is required.

UncleRus commented 1 year ago

At the moment, our CI is broken for versions esp-idf v4.x and esp8266. We'll have to wait until we fix it, but there's one thing you can fix right now: the README.md file must be generated as described in CONTRIBUTING.md. If you change it manually, the "Metadata" check will fail.

slimcdk commented 1 year ago

That explains it. README should be alright. Didn't have ruby / bundler installed, so entered it manually, but have since installed bundler and it didn't alter the contents.

I'm done fixing stuff, so should be ready for review now.

UncleRus commented 1 year ago

Well, great PR!

Will merge it as soon as we fix the CI and restart the checks :)