search

Uncodin / bypass

Skip the HTML, Bypass takes markdown and renders it directly on Android and iOS.
http://uncodin.github.com/bypass/
Apache License 2.0
1.52k stars 193 forks source link

Support for 'strike through' style by using 2 ~ to annotate on iOS #133

Closed myell0w closed 11 years ago

myell0w commented 11 years ago

This closes my own opened issue for adding support for strike through. It only gets parsed when "~ ~" is used to annotate, not when 1 or 3 ~ are used. Even though this is not part of the markdown specs afaik, this is a commonly used markdown annotation, e.g. supported by Github or Reddit.

cwc commented 11 years ago

Brace yourselves for pedantry.

cwc commented 11 years ago

:+1: functionality looks good.

heydamianc commented 11 years ago

I think that when you mention "Even though this is not part of the markdown specs afaik...", this change is hinting at something bigger. Prior to seeing your modifications, I wouldn't have liked the idea of inspecting the contents of the span-level elements in order to add another layer of parsing. However, it got me thinking that this could be our approach for handling nonstandard annotations, as you said. This way, libsoldout can naturally evolve, as well as our approach to displaying whatever is most useful for the targeted form factors.

This change will also require a modification to Bypass.java, so I'll let this sit a bit longer, but I really like this approach.

heydamianc commented 11 years ago

Refs #125

cwc commented 11 years ago

I edited the title to note that this is an iOS specific fix.

heydamianc commented 11 years ago

I pushed the contents of this pull request to the stable-ios branch.