search

UnconditionedLife / smum

SMUM Checkin for Santa Maria Urban Ministries (San Jose, California)
https://www.santamariasj.org
3 stars 0 forks source link

No Next Service Date is showing #112

Closed UnconditionedLife closed 2 years ago

UnconditionedLife commented 2 years ago

"Next Service date" should be showing with "Last Served date" --- all clients - all the time.

UnconditionedLife commented 2 years ago

An issue happened with the next service calculation being different for the receipt and the on-screen likely because of closure next Monday. The receipt was for today (Sat), but service was not available.

UnconditionedLife commented 2 years ago

"validateServiceInterval" function needs to use "calFindOpenDate" for the next service date calculated from calendar open and closed dates.

scott-r commented 2 years ago

I didn’t know about this bug, but it's another good reason for calling calFindOpenDate() from the Client code instead of Receipts.js.

Scott

On Feb 19, 2022, at 4:55 PM, Jose Leal @.***> wrote:

"validateServiceInterval" function needs to use "calFindOpenDate" for the next service date calculated from calendar open and closed dates.

— Reply to this email directly, view it on GitHub https://github.com/UnconditionedLife/smum/issues/112#issuecomment-1046134506, or unsubscribe https://github.com/notifications/unsubscribe-auth/AB5P4E2TILUXDXTT3L6GQATU4A3Y5ANCNFSM5O3OW5RA. Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub. You are receiving this because you are subscribed to this thread.

UnconditionedLife commented 2 years ago

I've used calFindOpenDate() to calculate both the next service date and active buttons this should correct the problems I observed.