UndeadKernel / pacfiles-mode

Emacs major mode to manage pacnew and pacsave files left by the pacman Arch tool
MIT License
42 stars 2 forks source link

Configuration variables are not defined as defcustom #6

Closed doolio closed 4 years ago

doolio commented 4 years ago

Firstly, thanks for this package. I was bitten by a recent change to some PAM config files and after resolving that issue I looked to see if I had inadvertenly neglected others in the past. Your package alerted me to several pacfiles I had neglected due to inexperience. So thank you.

The README lists a set of configuration variables which suggests these are customisable by the user which they are not. Should they be re-defined as defcustoms or clarified in the README?

Thanks for your time and this package.

UndeadKernel commented 4 years ago

Hey @doolio. I personally don't use the custom emacs facility but I guess it's a good idea to support it. However, there is only one variable that is meant to be changed by the user: pacfiles-updates-search-command. Well, you can technically also want to change pacfiles-merge-file-tmp-location. In the coming days I will make those two variables work with the customize framework.

By the way, you are free to change any variable in your init.el file with something like:

(with-eval-after-load "pacfiles-mode"
    (setq pacfiles-updates-search-command
        "find / -name '*.pacnew' -o -name '*.pacsave' 2>/dev/null"))
doolio commented 4 years ago
In the coming days I will make those two variables work with the customize framework.

Thanks, I might be unique in liking how the custom facility organises the various settings.

UndeadKernel commented 4 years ago

Solved in 8d06f64abc98c3f3338560c8d6eb47719e034069