search

UndefinedOffset / SortableGridField

Adds drag and drop functionality to Silverstripe's GridField
BSD 3-Clause "New" or "Revised" License
93 stars 62 forks source link

DOCS Update docs examples to be 3.1+ relevant #111

Closed dhensby closed 6 years ago

dhensby commented 6 years ago

The current examples in the 3.x compat branch reference how they are intended for 3.0 and public statics should be changed to private static. Given that 3.0 was EoL quite some time ago and devs are prone to just copy-pasting and not reading these notices, I think it's right that we show private static in the examples now.

I've also cleaned up the line length in the README as well as fixed a few typos and neatened up examples.

  1. Update examples to be 3.1+ compatible by default
  2. Fixed line lengths in README
  3. Fixed typos in README
  4. Added extra markup to class names in README
  5. Linked to GitHub releases page rather than to master.zip when suggesting manual download
UndefinedOffset commented 6 years ago

Thanks, technically it still works on 3.0 too ;) but you are right it's super old and the only version it supports that uses public statics so best to update the docs around that.