Missing adaptions for SS 3.7 & PHP 7.2

UndefinedOffset / SortableGridField

Adds drag and drop functionality to Silverstripe's GridField

BSD 3-Clause "New" or "Revised" License

93 stars 62 forks source link

Missing adaptions for SS 3.7 & PHP 7.2 #124

Closed th3hamm0r closed 5 years ago

th3hamm0r commented 5 years ago

Two usages of Object have not been replaced with SS_Object in #123 .

UndefinedOffset commented 5 years ago

In order to maintain compatibility with 3.6 can you add the following to _config.php

if(!class_exists('SS_Object')) {
    class_alias('Object', 'SS_Object');
}

th3hamm0r commented 5 years ago

This check has been added already in #123. That pull request just has missed two remaining occurrences of Object. My pull is based on the latest 1.0.x branch, or have I failed? ;)

UndefinedOffset commented 5 years ago

Oh haha my bad... merged

UndefinedOffset commented 5 years ago

thanks :)

th3hamm0r commented 5 years ago

Np, thx for the quick response!