not sure if this is working properly on V2

UndefinedOffset / silverstripe-nocaptcha

A spam protector and form field using Google's reCAPTCHA v2 or optionally a foundation v3 implementation

BSD 3-Clause "New" or "Revised" License

31 stars 37 forks source link

not sure if this is working properly on V2 #80

Closed sunnysideup closed 1 year ago

sunnysideup commented 1 year ago

I am looking here:

https://github.com/UndefinedOffset/silverstripe-nocaptcha/blob/master/src/Forms/NocaptchaField.php#L313-L316

I wonder:

a. when it is successful, success = 1, this means that success = 0 should be error?

b. if no success key is returned then it will not throw an error.

UndefinedOffset commented 1 year ago

I think b is a good point I've made an adjustment to account for that case however with a based on what I'm reading here success is boolean true or false so I think that case is covered right.

sunnysideup commented 1 year ago

Great! Thank you for looking at this.

UndefinedOffset commented 1 year ago

Tag coming soonish, waiting for SS5 to hit RC/find some time to confirm this works properly there. 99% sure it'll work just fine, I just haven't had the time to test 😄