search

UnderminersTeam / UndertaleModTool

The most complete tool for modding, decompiling and unpacking Undertale (and other GameMaker games!)
GNU General Public License v3.0
1.17k stars 223 forks source link

Incorrect decompilation in deltarune repainted #1394

Open H-A-M-G-E-R opened 1 year ago

H-A-M-G-E-R commented 1 year ago

Describe the bug

in lines 241 and 269 in gml_Object_obj_checkers_enemy_Step_0 in nudealert (deltarune repainted) 1.0.0 data.win, there's an oddity: 241: if (acting == true && actcon == 0) 269: if (acting == 2 && actcon == 0)

Reproducing steps

look at lines 241 and 269 in gml_Object_obj_checkers_enemy_Step_0 in nudealert (deltarune repainted) 1.0.0 data.win

Setup Details

undertalemodtool version v0.5.1.0

H-A-M-G-E-R commented 1 year ago

P.S. i used CheckDecompiler.csx in nudealert's data.win and some of them are different an odd one is gml_Script_scr_armorget.asm

Romualdo666 commented 1 year ago

I don't get it. What would be the weird thing here...?

Miepee commented 5 months ago

@H-A-M-G-E-R please provide more info on what exactly is the oddity / what you expected instead.

colinator27 commented 4 months ago

The problem here is that acting is being resolved as a boolean, when it's not. This will be fixed when the Underanalyzer decompiler is merged in.