search

UnderminersTeam / UndertaleModTool

The most complete tool for modding, decompiling and unpacking Undertale (and other GameMaker games!)
GNU General Public License v3.0
1.17k stars 223 forks source link

Disassembly and decompilation fails after renaming function #1428

Open Archie-osu opened 1 year ago

Archie-osu commented 1 year ago

Describe the bug

Got it on video: http://www.youtube.com/watch?v=_p6gToWKurE

Reproducing steps

Step 1: Open a data.win file Step 2: Define your own, unique function Step 3: Rename the function Step 4: Observe a decompiler / disassembler breakdown

Setup Details

  1. UndertaleModTool version: 0.5.1.0 (fa327ab)
  2. Operating system: Windows 10 Pro 22H2, 19045.3086
  3. GameMaker Game: Will You Snail (Sandbox Beta)
Jacky720 commented 1 year ago

Please try updating to the latest bleeding edge. This should have been fixed by #1351

Archie-osu commented 1 year ago

This is on the latest bleeding edge release. The commit matches.

colinator27 commented 4 months ago

This seems like a compiler bug that still affects the Underanalyzer decompiler fork - we should investigate if the struct function pruning affects this at all. I think the problem is that a function isn't getting deleted properly when renamed (or possibly when removed in any way).