search

UnderminersTeam / UndertaleModTool

The most complete tool for modding, decompiling and unpacking Undertale (and other GameMaker games!)
GNU General Public License v3.0
1.13k stars 213 forks source link

Importing graphics doesn't always work #1490

Open Imaynotbehere4long opened 11 months ago

Imaynotbehere4long commented 11 months ago

Describe the bug

Both of these edge cases can be found in the Violet Wisteria demo (which is free):

First, while importing most sprites works fine, the Aug 16 Bleeding-Edge version (single file) doesn't import altered cutscene graphics properly, even though it works fine on version 0.5.1.0 (also single file). On re-extraction, I found that it deleted part of the file name during the import process:

umt

Notice that the edit for sprCutscene2_10.png didn't get imported at all because, after the Aug 16 Bleeding-Edge version removed the "2", it ended up with the exact same file name as the previous edited file.

The second bug happens on both the Aug 16 Bleeding-Edge version and version 0.5.1.0. Whenever I export all textures, I end up with a background file that looks like this:

umt0

....which may very well be accurate, but whenever I try to import the backgrounds and save the altered data.win file, I get this error message, even when I don't change anything:

umt1

I did not test either issue on any of the the non-single-file builds.

Reproducing steps

  1. Download the free demo for Violet Wisteria and open its data.win file with the Single-File Aug 16 Bleeding-Edge version of UndertaleModTool.
  2. Export All Textures.
  3. Doodle something on the cutscene graphics to help you keep track of the edited files.
  4. Import Graphics (sprite folder)
  5. Save the data.win file and play the demo to see that the cutscenes after the opening haven't changed, then reopen the data.win file and Export All Sprites to see that the file names for the edited images were altered.
  6. Import Graphics (background folder) and try to save.

Setup Details

  1. Version of UndertaleModTool used (both bugs): https://github.com/krzys-h/UndertaleModTool/releases/download/bleeding-edge/GUI-windows-latest-Debug-isBundled-true-isSingleFile-true.zip
  2. OTHER version of UndertaleModTool used (only second bug): https://github.com/krzys-h/UndertaleModTool/releases/download/0.5.1.0/UndertaleModTool_v0.5.1.0-SingleFile.zip
  3. Operating system: Windows 10
  4. Game (it's a free demo): https://store.steampowered.com/app/2018610/Violet_Wisteria/
Miepee commented 3 months ago

I wonder if the first issue is caused by https://github.com/UnderminersTeam/UndertaleModTool/pull/1369

Imaynotbehere4long commented 1 month ago

I figured out the cause of the second issue! The "_0" isn't supposed to be part of the backgrounds' file names, but UndertaleModTool added it to them anyway upon extraction! Deleting those two characters allow the edited backgrounds to be imported and saved, properly replacing their original graphics.

By the way, the Jul 18 Bleeding Edge version (released 7 hours ago) imports the cutscene graphics properly, but it still adds the "_0" to the extracted backgrounds' file names, so I'm not sure if the issue is technically solved. I'll leave it open just in case.