search

UnderminersTeam / UndertaleModTool

The most complete tool for modding, decompiling and unpacking Undertale (and other GameMaker games!)
GNU General Public License v3.0
1.16k stars 225 forks source link

Object reference not set to instance of an object. #1523

Closed GavinFF-SS closed 11 months ago

GavinFF-SS commented 11 months ago

Describe the bug

When saving a room in my (don't lock me up sugary devs, if anyone of you is in here) Sugary Spire P-Rank Build mod, I was adding a new room, and when I saved with a new layer added, even with nothing in the layer, it still didn't save. Screenshot 2023-11-13 210833

Reproducing steps

  1. Add new room to P-Rank Build with Candied Chasedown installed.
  2. Add layer to that room.
  3. Save.
  4. Error that I thought was already fixed.

Setup Details

  1. UMT Version: Latest Bleeding Edge, also tested with a UMT:CE in the Pizza Tower gamebanana.
  2. OS: Windows.
  3. GameMaker Game: Sugary Spire: P-Rank Build that was leaked. Not sure if I can even talk about this here, but I'm definitely not linking to it. If uploading the .win is required (probably will be) then I guess I'm either jailed, or quitting attempting to add the room.
GavinFF-SS commented 11 months ago

More info about this, I tested with UMT 5.1 and the inability to save only happened when I added an asset layer. With only an instance layer, it's fine.

VladiStep commented 11 months ago

Hmm, I feel it's some bug that could be easily fixed, probably even without providing the data file

GavinFF-SS commented 11 months ago

I was told by the lead dev of Candied Chasedown that it's unfixable because it's something with how UMT edits code, and can only be fixed with an update.

VladiStep commented 11 months ago

I was told by the lead dev of Candied Chasedown that it's unfixable because it's something with how UMT edits code, and can only be fixed with an update.

The error doesn't seem to be related to code

GavinFF-SS commented 11 months ago

well then how might I fix it? If you know, of course.

Jacky720 commented 11 months ago

I assume VladiStep is referring to a fix to UTMT's code being relatively easy, but that's for someone who has the experience with the codebase to know where to look and what to look for.

GavinFF-SS commented 11 months ago

Yeah, I know for a fact I'm not a someone with experience with the codebase.

GavinFF-SS commented 11 months ago

Going to (attempt) to merge this into a build and report back if it works.

GavinFF-SS commented 11 months ago

Thanks for everyone's assistance on this, this is fixed with #1526!