UnderminersTeam / UndertaleModTool

The most complete tool for modding, decompiling and unpacking Undertale (and other Game Maker: Studio games!)
GNU General Public License v3.0
1.07k stars 206 forks source link

Embedded Texture view should scroll with Ctrl or Shift down #1558

Open Fried-Potato-Chip opened 7 months ago

Fried-Potato-Chip commented 7 months ago

Which component should be improved?

UI/UX

Describe your feature suggestion in more detail

Currently, using the mouse wheel, zooms in/out a view of a Embedded Texture, but this should happen when CTRL is pressed down, otherwise, the view scrolls vertically. Additionally, holding the SHIFT key should scroll the view horizontally.

This combination of keys is usually present in photo editing software or web browsers, making it potentially expected by someone using UMT.

I might not explain this in an understandable manner, so this pseudo-code (hopefully) makes my point clear.

if (IsKeyDown(CTRL)) 
{
    doZoom(); // Use the mouse wheel to zoom in or out
} 
else if (IsKeyDown(SHIFT)) 
{
    doScrollHorizonally(); // Use the mouse wheel to scroll horizontally
}
else 
{
    doScrollVertically(); // Use the mouse wheel to scroll vertically
}

Note: do not implement it like this Note 2: this may also apply to other image views, but this is the one that I encountered

Miepee commented 5 months ago

This combination of keys is usually present in photo editing software

This actually heavily depends on the photo editing software. There are a few that by default have zoom in/out without CTRL, like krita

Fried-Potato-Chip commented 5 months ago

This actually heavily depends on the photo editing software. There are a few that by default have zoom in/out without CTRL, like krita

That's right, but zoom in/out without any modifier (CTRL, SHIFT, ALT, etc) can be weird if you have two nested scrollable surfaces (ex. Image inside object details), I would think that's why browsers have them when zooming.