search

UnderminersTeam / UndertaleModTool

The most complete tool for modding, decompiling and unpacking Undertale (and other GameMaker games!)
GNU General Public License v3.0
1.14k stars 219 forks source link

New and modified sounds in VA-11 Hall-A break #1699

Open Jacky720 opened 7 months ago

Jacky720 commented 7 months ago

Describe the bug

Originally reported on Discord by someone who didn't want to make a fuss over it :P

Adding EmbeddedSound 120 (I assume the original goes up to 119 or less) allows the sound entry to reference the embedded audio by ID, but rather than appear as (UndertaleEmbeddedAudio#120) as expected, UTMT shows (UndertaleEmbeddedAudio#120 in UndertaleAudioGroup#-1:audiogroup_default) and the sound cannot be played in game. This may also occur when editing the IDs of existing sounds. In debugging, aim to figure out the difference between the two displays and how new sounds should be reliably added based on audiogroup configurations (maybe the audiogroup.dat file needs to be updated?)

Reproducing steps

  1. Open VA-11 Hall-A.
  2. Add a new embedded audio file.
  3. Assigning the new audio's ID to a sound causes the instability.

Setup Details

  1. UndertaleModTool version: Presumably 0.5.1.0 or approx. 3d5c24c61a7acd8c7a9d27832ddb972e27b660f4; audio handling hasn't changed in a while so I didn't recommend updating, it seemed unlikely to be the root cause.
  2. Operating system: Presumably Windows 10 or 11, appears to be a tool bug unrelated to OS
  3. VA-11 Hall-A
Jacky720 commented 5 months ago

I'm not sure if #1738 is the direct cause, but it certainly makes things harder to analyze.