UnderminersTeam / UndertaleModTool

The most complete tool for modding, decompiling and unpacking Undertale (and other GameMaker games!)
GNU General Public License v3.0
1.19k stars 233 forks source link

Memory Optimization to not resize a dictionary #1807

Closed Miepee closed 4 months ago

Miepee commented 5 months ago

Description

See the comment in the diff. Saved for me ~40MB in the Large Object Heap.

Caveats

Slightly more unreadable code.

Notes

N/A

github-actions[bot] commented 5 months ago

Download the artifacts for this pull request here:

GUI:

CLI:

VladiStep commented 5 months ago

I think you should add a null check in the beginning so it only clears scripts and assetIds if Data is null.