search

UnderminersTeam / UndertaleModTool

The most complete tool for modding, decompiling and unpacking Undertale (and other GameMaker games!)
GNU General Public License v3.0
1.19k stars 233 forks source link

Supply script file paths, better script exceptions #1850

Closed colinator27 closed 4 months ago

colinator27 commented 4 months ago

Description

Based on code from https://github.com/UnderminersTeam/UndertaleModTool/pull/1504. Modified to fix the root cause of the problem (file paths/encodings not being specified in ScriptOptions), rather than using regular expressions to work around it.

Also includes the improved script stack traces/exception handling, but further cleaned up and commented.

Caveats

As mentioned in the above PR, this does make exceptions slightly more verbose (even for single scripts), but this is probably a welcome change.

Notes

Tested to work with built-in scripts and UMP.

github-actions[bot] commented 4 months ago

Download the artifacts for this pull request here:

GUI:

CLI:

colinator27 commented 4 months ago

How does the CLI handle this?

CLI just specifies the file path and encoding now, so #load will work properly there too. There's no updated exception handling for it like there is in the GUI, though (it'll be the same as before).