search

UnderminersTeam / UndertaleModTool

The most complete tool for modding, decompiling and unpacking Undertale (and other GameMaker games!)
GNU General Public License v3.0
1.19k stars 233 forks source link

Use buffer for reading JSON in UndertaleWithJSONs #1856

Closed Dobby233Liu closed 3 months ago

Dobby233Liu commented 3 months ago

Description

This makes the loading of lang JSONs almost instantaneous

Caveats

Unclear, it works in v1.08 and v1.11

Notes

Code copied from DR Ch1&2

github-actions[bot] commented 3 months ago

Download the artifacts for this pull request here:

GUI:

CLI:

colinator27 commented 3 months ago

We may hold off on merging this until after the next major release, but it looks good to me! These changes will have to be merged with the additional rewrite of this script that occurred on the underanalyzer branch, though it should be easy I think.