search

UnderminersTeam / UndertaleModTool

The most complete tool for modding, decompiling and unpacking Undertale (and other GameMaker games!)
GNU General Public License v3.0
1.19k stars 233 forks source link

Fix Branch being overwritten less precisely #1874

Closed Jacky720 closed 3 months ago

Jacky720 commented 3 months ago

Description

The method TestForCommonGMSVersions estimates the version of a WAD based on which chunks are present. This is invoked twice: once at the start of deserialization, and once while parsing the GEN8 (General Info) chunk. The second case is... actually, it's completely redundant, so this PR removes it. This fixes the identification of non-LTS 2023.1 in TGIN and therefore closes #1873.

Caveats

N/A

Notes

N/A

github-actions[bot] commented 3 months ago

Download the artifacts for this pull request here:

GUI:

CLI:

colinator27 commented 3 months ago

Tested on a wide range of GameMaker versions, seems to be pretty stable.