search

UnderminersTeam / UndertaleModTool

The most complete tool for modding, decompiling and unpacking Undertale (and other GameMaker games!)
GNU General Public License v3.0
1.19k stars 233 forks source link

Clean up some warnings and errors #1894

Open colinator27 opened 3 months ago

colinator27 commented 3 months ago

Description

PR checks have been plagued with tons of warning messages at the end (at least with GitHub's beta "Unchanged files with check annotations"), so this PR aims to get rid of a bunch of them.

Caveats

WebClient was replaced with HttpClient, so there may be slight behavioral differences. I did test the updater, though, and it functioned fine.

Some files now have #pragma directives to disable cross-platform compatibility warnings, but I limited this specifically to GUI, which is already Windows-only, at least as it stands.

Notes

Starting this as a draft to make sure the warnings no longer show up in the build pipeline. This seems to have worked.

github-actions[bot] commented 3 months ago

Download the artifacts for this pull request here:

GUI:

CLI: