search

UnderminersTeam / UndertaleModTool

The most complete tool for modding, decompiling and unpacking Undertale (and other GameMaker games!)
GNU General Public License v3.0
1.12k stars 213 forks source link

scr_namingscreen Decompilation Error (New Decompiler) #235

Open theclashingfritz opened 4 years ago

theclashingfritz commented 4 years ago

This probably exists in the old one as well but in the new decompiler there's a couple of break sections that are left without an proper break in scr_namingscreen for entering you name.

The code should decompile to if ((selected_col < 0) || ((selected_row < 0) || (string_length(charmap[selected_row, selected_col]) > 0))) { break } else { continue } but instead decompiles to if ((selected_col < 0) || ((selected_row < 0) || (string_length(charmap[selected_row, selected_col]) > 0))) { } else { continue }

Grossley commented 4 years ago

This might be related to #224 . Good find. :)

theclashingfritz commented 4 years ago

They are likely linked. Though in which ways is not yet known.

Grossley commented 4 years ago

So as it turns out this actually causes the game to freeze upon selecting "Begin Game". This needs to be corrected in the future (and I assume errors of this type will be addressed later on when the decompiler rewrite is done).