New Room editor feature is already bugeed.

[ToughSun14]

So, recently, a new commit was made to the source code, and one thing that was improved is the room viewer, but it appears to already be bugged. For anything that uses a sprite as a visual marker, instead of simply drawing the target position and size for the asset's sprite, it draws its source position and size, meaning other sprites can unnecessarily overlap into it. An example of this can be found in room_torhouse. The tile for "bg_torhouse_fg" overlaps into other sprites on its texture page. Addendum: Did some experimenting with previews, turns out if a sprite asset has multiple frames, the room viewer can only draw frame 0, even if the asset is set to a different frame.

[VladiStep]

I don't understand the first part - what's exactly wrong with this room? Could you highlight it on the picture? And about sprite instance frame index - I just didn't noticed that it has "frame index" property, it will be fixed in the next pull request.

[ToughSun14]

I've highlighted the issue with a red rectangle.

[VladiStep]

Oh, I thought this labels were written by you. Also, you didn't mentioned that is latest version of Deltarune.

[ToughSun14]

Well, it is the latest version of Deltarune, but it's also the latest commit to the master branch.

[VladiStep]

I think problem is simply that it doesn't use margin properties of sprite (MarginLeft, MarginRight, MarginTop, MarginBottom).

[ToughSun14]

Hmm, good point. Kinda lines up with my guess where instead of using the target position variables to draw the sprite, it uses the source position variables.

[VladiStep]

Actually, it was "bugged" from the beginning (at least from September 2018).