Closed spooonsss closed 1 year ago
Hmm, it occurs to me that this may be an intentional design decision to not detect things that conflict with only the initial_patch.bps. It's unfortunate that this harmful conflict isn't detected.
I'm guessing you have "InitialPatch"
in your ignored_conflict_symbols
, which is why that conflict isn't included.
EDIT: Got ninja'd. Yes, it's intentional. Not ignoring the initial patch conflicts gives me 201 conflicts on your setup, most of which are probably useless, which is why it's ignored by default in my config.
Adding SA-1 to the list of patches is an ok workaround.
Conflict - 0x2 bytes at SNES: $00A2E7 (unheadered), PC: 0x0024E7 (headered):
Original bytes:
B1 8A
Initial Patch:
04 B8
Patch (resources\patches\nsmbwssb+SC.asm):
DD CF
Patch (resources\patches\SA1-Pack-140\sa1.asm):
04 B8
Using: https://github.com/spooonsss/smw-project-template/tree/conflict-undetected
nsmbwssb+SC.asm
has:smw-project-template/resources/initial_patch.bps
hasfrom
SA1-Pack-140/boost/level_mode.asm:org $00A2E6
After doing a rebuild in Callisto,
conflicts.txt
contains:The conflict at $00A2E7 should be included in this output.