search

UnderwaterApps / overlap2d-runtime-libgdx

Overlap2D - UI and Level Editor libgdx runtime
http://overlap2d.com
Other
170 stars 96 forks source link

Double creating of spriterAnimations #66

Closed Pretzel777 closed 8 years ago

Pretzel777 commented 8 years ago

EntityFactory line 299. for (int i = 0; i < vo.sSpriterAnimations.size(); i++) { Entity child = createEntity(entity, vo.sSpriterAnimations.get(i)); engine.addEntity(child); } is duplicated.

azakhary commented 8 years ago

Hi, could you do a pull request so I can merge your changes right away?

Pretzel777 commented 8 years ago

Hi, yes sure. Maked pull request right now. Is it all ok?

azakhary commented 8 years ago

hmm. no no marking, Pull Requests are suggestions of code change, made from your Fork to main repo here, https://github.com/UnderwaterApps/overlap2d-runtime-libgdx/pulls

Usually when someone notices a necessary code change, they can change that on their fork of this repo, and then use create pull request button to propose the change, I (and/or others) then can review the proposed change, and merge is it makes sense.

azakhary commented 8 years ago

There is an easier way to do it by guithub, you can click "edit" the file here on github, and then it will create the pull request for you.

azakhary commented 8 years ago

Here, read this: https://help.github.com/articles/editing-files-in-another-user-s-repository/

Pretzel777 commented 8 years ago

Ok, thanks for information. Maked it by edit on github.

JaraClaudioEz commented 8 years ago

Is this already fixed? because i refresh dependencies and still is duplicated. Thanks

azakhary commented 8 years ago

Just baked the latest build to maven central, will take 5 minutes or so (make sure to clear caches) marking it as resolved.