search

UnderwaterApps / overlap2d-runtime-libgdx

Overlap2D - UI and Level Editor libgdx runtime
http://overlap2d.com
Other
170 stars 96 forks source link

squid:S2039 - Member variable visibility should be specified #96

Closed m-ezzat closed 8 years ago

m-ezzat commented 8 years ago

This pull request is focused on resolving occurrences of Sonar rule squid:S2039 - Member variable visibility should be specified

You can find more information about the issue here: https://dev.eclipse.org/sonar/coding_rules#q=squid:S2039

Please let me know if you have any questions.

M-Ezzat

azakhary commented 8 years ago

Sorry can't merge this, it's automated code analysis.

m-ezzat commented 8 years ago

Hi @azakhary can you please let me know which files exactly are the undesired ? that's to avoid them from now on for the following PRs, and if there's a possibility to revert them from this PR as well. Thanks !

azakhary commented 8 years ago

Sure, we cannot change stuff in com.brashmonkey

azakhary commented 8 years ago

I can reopen this, if you just revert the brashmonkey stuff.

m-ezzat commented 8 years ago

Ok, thanks! I reverted them.

m-ezzat commented 8 years ago

I am not sure whether you do not agree with these changes or not. Please close this PR if not.