search

UnderwaterApps / overlap2d

Overlap2D Game development toolkit for UI and Level design
Other
780 stars 224 forks source link

Duplicated (even triplicated) Notifier interface #292

Open nikoliazekter opened 9 years ago

nikoliazekter commented 9 years ago

SimpleMediator implements Notifier interface thrice! (kinda) https://github.com/UnderwaterApps/overlap2d/edit/master/overlap2d-common-api/src/com/puremvc/patterns/mediator/SimpleMediator.java This code is really weird. First, since Mediator already extends Notifierwhy do we need it to implement Notifier again? Second, why doesn't BaseNotifier implement Notifier? Third, BaseNotifier is Notifier and Mediator is Notifier. I think that it's better to remove extends Notifier from Mediator to make code clearer. I actually was going to create PR with some changes but figured out that I need your agreement what do with all this code.

azakhary commented 9 years ago

Oh, this part is spooky, it was done by @saqsun , but I think it was also copied from somewhere. @saqsun can you help us out with advice on this? Thanks.

nikoliazekter commented 8 years ago

Apparently @saqsun can't help us with this.

azakhary commented 8 years ago

yeah. I guess I'll take a look. but this is copied from somewhere, so had to be correct. I'll check