search

Unee-T-INS / invite

API to process invitations, i.e. write data from Meteor into the Aurora DB
https://invite.dev.ins.unee-t.com/
GNU Affero General Public License v3.0
0 stars 1 forks source link

Phase 1 - Remove hard coded variables #1

Closed franck-boullier closed 4 years ago

franck-boullier commented 4 years ago

This PR is to standardize how we store environment-specific parameters.

We need to store environment-specific parameters more efficiently than the current implementation where environment-specific variables are hardcoded in 20 different files.

Ideally, environment variables should be maintained in only 3 places:

kaihendry commented 4 years ago

https://travis-ci.org/Unee-T-INS/invite/builds/635612795?utm_source=github_status&utm_medium=notification didn't pass CI since Travis doesn't have the ins-dev profile setup in it's environment.

I can't fix that yet, since I don't seem to have permission to do that in Travis.

This PR is all over the place & too much of a hassle to fix.

The main reason for the "hard coded" -ins imports are changes like not using MYSQL_USER & MYSQL_PASSWORD anymore. Else we could have carried on using unee-t/env (once the $STAGE/$DOMAIN change was applied) and not needed to change the imports.