GITHUB_TOKEN needs to be set

[tuananh1508]

This is error message on Travis CI, see line 448 : https://travis-ci.org/Unee-T-INS/invite/builds/636820279

$ travis_script_go -v go generate jq '.profile |= "" | .role |= "" | .vpc.subnets |= [ "", "", "" ] | .vpc.securityGroups |= [ "" ]' project.dev.json.in > project.dev.json

Travis file: https://github.com/Unee-T-INS/invite/blob/8120a262e85792fef81b4c1c911d4ace074ba5c8/.travis.yml#L50

Issue: Travis always runs the Make file: https://github.com/Unee-T-INS/invite/blob/remove_hard_coded_variables/Makefile

the expect file to run: https://github.com/Unee-T-INS/invite/blob/remove_hard_coded_variables/web/deploy.sh

[kaihendry]

I guess you use the proposal I made here by grabbing the values from PRIVATESUBNET{1,2,3} & DEFAULT_SECURITY_GROUP https://github.com/Unee-T-INS/invite/commit/e883c7a6a948aa315304247233fbd3c569959c58

invites was not designed to be deployed by "deploy.sh", so I am not sure it's worth the effort

[franck-boullier]

@kaihendry I was looking at your proposed code (55e3bb124749a29a96321fd855161d4e3256be5c).

Unfortunately the Travis build failed too (https://travis-ci.org/Unee-T-INS/invite/builds/635612795#L414) so it seems that your proposal is not working either.

Any idea on how we could fix that?

[kaihendry]

I'll fix it

[kaihendry]

https://travis-ci.org/Unee-T-INS/invite is passing. GITHUB_TOKEN needs to be set in order for it reliably download up

[franck-boullier]

GITHUB_TOKEN needs to be set in order for it reliably download up

@kaihendry

• What is the variable GITHUB_TOKEN?
• Where do we get that variable?
• Where do we set that variable? It doesn't seem to be either in the code you've just committed, it does not seem to be in the AWS parameter store, it doesn't seem to be one of the Travis CI settings... :thinking:

More information about this variable GITHUB_TOKEN would be good so we can understand what you're talking about

[kaihendry]

https://help.github.com/en/github/authenticating-to-github/creating-a-personal-access-token-for-the-command-line#creating-a-token

It's needed for authenticated downloads from Github and to prevent rate limiting. It's only useful in the context of the travis environment. It could conceivably be set from the parameter store.