franck-boullier
commented
4 years ago Btw you can test invite is working like so:
We did that and it passed the test so we thought that there was no issue. It seems that either the test is not exhaustive enough or that something else is at play here with issue https://github.com/Unee-T-INS/frontend/issues/11#issuecomment-575612709.
The deploy.sh script makes no sense.
@kaihendry I still don't understand why are you so hostile yo the idea of using the deploy.sh script method...
The deploy.sh script method is, as of today, the only workable way we could find to get the variables setup correctly.
I hear that you have an alternative proposal but despite all our best efforts (and we spend MANY hours trying to decypher what you are trying to tell us) we haven't been able to make it work yet and that's why we had no other choices but to implement the deploy.sh option since it allows us to set environment variable correctly.
Just to reiterate: our current understanding of the Makefile option does NOT set the variables as we need them.
In order to move on this deadlock something has to change i.e:
- We get a better understanding of the Makefile option so we are able to make it work as we want things to work.
- You get a better understanding of why we feel we can NOT use the Makefile option at this stage. Barring that I'm afraid we'll get stuck on this topic.
If we deploy as I proposed with make PROFILE=${AWS_PROFILE_DEV} from .travis.yml we need not have {demo,prod} targets in the Makefile
Not sure I agree with that: DEV is deployed when Master is updated, DEMO and PROD are built when we do a tag release. How sill this work with the code that you proposed?
https://github.com/Unee-T-INS/invite/blob/master/up.json.in doesn't belong here since it's deployed from https://github.com/Unee-T-INS/invite/tree/master/web (not the top level directory).
This is not true anymore: we altered the code in the latest version of the Master.
tuananh1508
Your changes have broken the deployment of invite. Error is
sh: ./server: No such file or directoryI redeployed manually to make it work.
Btw you can test invite is working like so:
The deploy.sh script makes no sense.
TRAVIS_PROFILE is ... AWS_PROFILE? So why change it?
If we deploy as I proposed with
make PROFILE=${AWS_PROFILE_DEV}from .travis.yml we need not have {demo,prod} targets in the Makefile as I had here: https://github.com/Unee-T-INS/invite/blob/ff3328eafd2fd29a7c8db74cdce77f262f74e9df/web/Makefilehttps://github.com/Unee-T-INS/invite/blob/master/up.json.in doesn't belong here since it's deployed from https://github.com/Unee-T-INS/invite/tree/master/web (not the top level directory).