search

UnevenSoftware / LeafPic

LeafPic is a fluid, material-designed alternative gallery, it also is ad-free and open source under GPLv3 license. It doesn't miss any of the main features of a stock gallery, and we also have plans to add more useful features.
GNU General Public License v3.0
3.27k stars 1.35k forks source link

Enable, Disable internal video player option fastly crashes the app #541

Closed ms10398 closed 6 years ago

ms10398 commented 6 years ago

Expected behavior

Internal video player option should work when enable and work according to it. And stopped working when we disable it or repeat the same steps any no. of times.

Actual behavior

When we enable the Internal video olayer option and then disable it and repeat this process will crash the app and app stopped working.

How to reproduce

  • Open the settings menu of Leafpic and enable the Internal Video Player option as shown in this Screenshot. IMG-20180408-WA0018.jpg
  • Now disable this option and repeat same process atleast 3 times with no break in time.
  • Leafpic: Version 0.6-beta-1
  • Operating system: Android Nougat 7.0

Recording Of The Bug

Recording of the bug can be found here - https://www.youtube.com/embed/jYdlB8R27vY?autoplay=1


Posted on Utopian.io - Rewarding Open Source Contributors

ms10398 commented 6 years ago

This issue was reported by @rockstar96969696

And I found a similar issue closed here -

https://github.com/HoraApps/LeafPic/issues/405

calvinnor commented 6 years ago

@ms10398 Hi Mohit!

This option has been removed as of 0.7 (unreleased), probably why #405 was closed without comment. It has been replaced with a lot of rework and a better video player. Will update you on this when we're ready for release, so that you can verify if we fixed your issue.

Thanks!

ms10398 commented 6 years ago

Thanks @CalvinNor :slightly_smiling_face: