search

UnevenSoftware / LeafPic

LeafPic is a fluid, material-designed alternative gallery, it also is ad-free and open source under GPLv3 license. It doesn't miss any of the main features of a stock gallery, and we also have plans to add more useful features.
GNU General Public License v3.0
3.27k stars 1.35k forks source link

externally opened videoes cause non transparent & underlapping player design #588

Open lkd70 opened 6 years ago

lkd70 commented 6 years ago

Description

When opening a video from an external source (e.g: File Manager) in LeafPic video player, the control bars (top and bottom) show in the primary color, opposed to the normal transparent black color. The video will also overlap the top control bar

Steps to reproduce

  1. Open an external media source (e.g: File Manager), locate a portrait video
  2. Open the video in Leaf Pic Video Player
  3. Turn the app in to landscape mode(examples)

Expected result

The player controls overlap the video when open The player controls are translucent and black, not Primary Color.

Actual result

The player controls are overlapped by the video when the player is in landscape mode, but is a portrait video. The player controls are Primary Color and not transparent. see examples

Additional Information

Examples

image showing both issues

dnldsht commented 6 years ago

the control bars (top and bottom) show in the primary color, opposed to the normal transparent black color

The ViewPager (the activity when you can scroll images) is different from the VideoPlayerActivity this explain the not transparent bars.

I don't know if is a good idea to move the VideoPlayer in a Fragment and show it in the ViewPager.. @CalvinNor would love to hear your thoughts on this.

Edit: for the overlapping issue would be easy to fix!